[gazelle] Fix 30s hang on javaparser shutdown; avoid GOAWAY noise #374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hang happened at shutdown because the server called `System.exit(0)` without replying to the `Lifecycle.Shutdown` RPC. The gRPC server then waited up to 30s with an in-flight call. Closing the client socket immediately would produce a (benign) “Broken pipe” GOAWAY stacktrace. This change results in far faster shutdown of the gRPC server.
shs96c
force-pushed
the
gazelle-fast-shutdown
branch
from
95b14ae to
aefb867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hang happened at shutdown because the server called
System.exit(0)without replying to theLifecycle.ShutdownRPC. The gRPC server then waited up to 30s with an in-flight call. Closing the client socket immediately would produce a (benign) “Broken pipe” GOAWAY stacktrace.This change results in far faster shutdown of the gRPC server.