Skip to content

Conversation

@jeffmace
Copy link

This updates the java_junit5_test rule to support a main_class attribute and pass it on to java_test if provided. The default value is moved to a constant but remains unchanged.

Copy link

@mzeren-vmw mzeren-vmw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and test works for me.

@shs96c
Copy link
Collaborator

shs96c commented Oct 25, 2025

The main thing that the java_junit5_test does is set the main_class. I'm not sure what the value of allowing that key detail to be overridden gives. Could you please explain a little more about the use case for this change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants