Implement intermediate SBOM generation and SPDX serialization #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yannic
reviewed
Sep 4, 2025
| @@ -0,0 +1,23 @@ | |||
| load("@rules_go//go:def.bzl", "go_binary", "go_library") | |||
There was a problem hiding this comment.
I'd put this into //sbom/spdx/generator. I'd like to keep //lib/supplychain-go light and not pull in lots of dependencies for all kinds of sbom formats
Yannic
reviewed
Sep 4, 2025
|
|
||
| go_library( | ||
| name = "supply-chain-go", | ||
| name = "supplychain-go", |
There was a problem hiding this comment.
Mind splitting this one out into its own PR?
Also, we should probably add an alias for the old name
Yannic
reviewed
Sep 4, 2025
| return rule( | ||
| _sbom_impl, | ||
| attrs = { | ||
| "target": attr.label(aspects = [gathering_aspect], doc="The target for which to generate an SBOM."), |
There was a problem hiding this comment.
From internal experience, this should be label_list
Yannic
reviewed
Sep 4, 2025
| return gather_metadata_info_common( | ||
| target, | ||
| ctx, | ||
| want_providers = [PackageAttributeInfo, PackageMetadataInfo, LicenseKindInfo], |
There was a problem hiding this comment.
What do we need AttributeInfo and LicenseKindInfo for? They are referenced in the JSON file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows a user to create an intermediate sbom format via the sbom target that can later be consumed into a serialized format like SPDX by specialized rules.