Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions docs/metadata/defs.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,49 @@ Provider for declaring metadata about a Bazel package.
| <a id="PackageMetadataInfo-files"></a>files | A [depset](https://bazel.build/rules/lib/builtins/depset) of [File](https://bazel.build/rules/lib/builtins/File)s with metadata about the package, including transitive files from all attributes of the package. | `[]` |


<a id="PackageMetadataOverrideInfo"></a>

## PackageMetadataOverrideInfo

<pre>
load("@package_metadata//:defs.bzl", "PackageMetadataOverrideInfo")

PackageMetadataOverrideInfo(*, <a href="#PackageMetadataOverrideInfo-packages">packages</a>, <a href="#PackageMetadataOverrideInfo-metadata">metadata</a>)
</pre>

Defines an override for `PackageMetadataInfo` for a set of packages.

> **Fields in this provider are not covered by the stability gurantee.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in "gurantee". It should be "guarantee". This typo also appears in other new documentation and docstrings.

Suggested change
> **Fields in this provider are not covered by the stability gurantee.**
> **Fields in this provider are not covered by the stability guarantee.**


**FIELDS**

| Name | Description |
| :------------- | :------------- |
| <a id="PackageMetadataOverrideInfo-packages"></a>packages | A [PackageSpecificationInfo](https://bazel.build/rules/lib/providers/PackageSpecificationInfo) provider declaring which packages the override applies to.<br><br>This is typically created by a [package_group](https://bazel.build/rules/lib/globals/build#package_group) target. |
| <a id="PackageMetadataOverrideInfo-metadata"></a>metadata | The `PackageMetadataInfo` provider to use instead of the provider declared by package itself. |


<a id="PackageMetadataToolchainInfo"></a>

## PackageMetadataToolchainInfo

<pre>
load("@package_metadata//:defs.bzl", "PackageMetadataToolchainInfo")

PackageMetadataToolchainInfo(<a href="#PackageMetadataToolchainInfo-metadata_overrides">metadata_overrides</a>)
</pre>

Toolchain for `package_metadata`.

> **Fields in this provider are not covered by the stability gurantee.**

**FIELDS**

| Name | Description | Default Value |
| :------------- | :------------- | :------------- |
| <a id="PackageMetadataToolchainInfo-metadata_overrides"></a>metadata_overrides | A sequence of `PackageMetadataOverrideInfo` providers. | `[]` |


<a id="package_metadata"></a>

## package_metadata
Expand All @@ -70,6 +113,27 @@ package_metadata(*, <a href="#package_metadata-name">name</a>, <a href="#package
| <a id="package_metadata-visibility"></a>visibility | <p align="center"> - </p> | `None` |


<a id="package_metadata_toolchain"></a>

## package_metadata_toolchain

<pre>
load("@package_metadata//:defs.bzl", "package_metadata_toolchain")

package_metadata_toolchain(*, <a href="#package_metadata_toolchain-name">name</a>, <a href="#package_metadata_toolchain-visibility">visibility</a>)
</pre>



**PARAMETERS**


| Name | Description | Default Value |
| :------------- | :------------- | :------------- |
| <a id="package_metadata_toolchain-name"></a>name | <p align="center"> - </p> | none |
| <a id="package_metadata_toolchain-visibility"></a>visibility | <p align="center"> - </p> | `None` |
Comment on lines +133 to +134

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The descriptions for the name and visibility attributes are unhelpful placeholders (-). Please provide meaningful descriptions for these common attributes to improve documentation clarity. For example, for name: "A unique name for this target."



<a id="purl.bazel"></a>

## purl.bazel
Expand Down
52 changes: 23 additions & 29 deletions docs/metadata/providers/BUILD
Original file line number Diff line number Diff line change
@@ -1,32 +1,26 @@
load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
load("@stardoc//stardoc:stardoc.bzl", "stardoc")

stardoc(
name = "package_attribute_info",
out = "package_attribute_info.generated.md",
input = "@package_metadata//providers:package_attribute_info.bzl",
deps = [
"@package_metadata//providers:srcs",
],
)

diff_test(
name = "package_attribute_info_test",
file1 = ":package_attribute_info",
file2 = "package_attribute_info.md",
)

stardoc(
name = "package_metadata_info",
out = "package_metadata_info.generated.md",
input = "@package_metadata//providers:package_metadata_info.bzl",
deps = [
"@package_metadata//providers:srcs",
],
)

diff_test(
name = "package_metadata_info_test",
file1 = ":package_metadata_info",
file2 = "package_metadata_info.md",
)
[
[
stardoc(
name = file,
out = "{}.generated.md".format(file),
input = "@package_metadata//providers:{}.bzl".format(file),
deps = [
"@package_metadata//providers:srcs",
],
),
diff_test(
name = "{}_test".format(file),
file1 = ":{}".format(file),
file2 = "{}.md".format(file),
),
]
for file in [
"package_attribute_info",
"package_metadata_info",
"package_metadata_override_info",
"package_metadata_toolchain_info",
]
]
26 changes: 26 additions & 0 deletions docs/metadata/providers/package_metadata_override_info.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!-- Generated with Stardoc: http://skydoc.bazel.build -->

Declares provider `PackageMetadataOverrideInfo`.

<a id="PackageMetadataOverrideInfo"></a>

## PackageMetadataOverrideInfo

<pre>
load("@package_metadata//providers:package_metadata_override_info.bzl", "PackageMetadataOverrideInfo")

PackageMetadataOverrideInfo(*, <a href="#PackageMetadataOverrideInfo-packages">packages</a>, <a href="#PackageMetadataOverrideInfo-metadata">metadata</a>)
</pre>

Defines an override for `PackageMetadataInfo` for a set of packages.

> **Fields in this provider are not covered by the stability gurantee.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in "gurantee". It should be "guarantee".

Suggested change
> **Fields in this provider are not covered by the stability gurantee.**
> **Fields in this provider are not covered by the stability guarantee.**

**FIELDS**

| Name | Description |
| :------------- | :------------- |
| <a id="PackageMetadataOverrideInfo-packages"></a>packages | A [PackageSpecificationInfo](https://bazel.build/rules/lib/providers/PackageSpecificationInfo) provider declaring which packages the override applies to.<br><br>This is typically created by a [package_group](https://bazel.build/rules/lib/globals/build#package_group) target. |
| <a id="PackageMetadataOverrideInfo-metadata"></a>metadata | The `PackageMetadataInfo` provider to use instead of the provider declared by package itself. |


25 changes: 25 additions & 0 deletions docs/metadata/providers/package_metadata_toolchain_info.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!-- Generated with Stardoc: http://skydoc.bazel.build -->

Declares provider `PackageMetadataToolchainInfo`.

<a id="PackageMetadataToolchainInfo"></a>

## PackageMetadataToolchainInfo

<pre>
load("@package_metadata//providers:package_metadata_toolchain_info.bzl", "PackageMetadataToolchainInfo")

PackageMetadataToolchainInfo(<a href="#PackageMetadataToolchainInfo-metadata_overrides">metadata_overrides</a>)
</pre>

Toolchain for `package_metadata`.

> **Fields in this provider are not covered by the stability gurantee.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in "gurantee". It should be "guarantee".

Suggested change
> **Fields in this provider are not covered by the stability gurantee.**
> **Fields in this provider are not covered by the stability guarantee.**

**FIELDS**

| Name | Description | Default Value |
| :------------- | :------------- | :------------- |
| <a id="PackageMetadataToolchainInfo-metadata_overrides"></a>metadata_overrides | A sequence of `PackageMetadataOverrideInfo` providers. | `[]` |


35 changes: 21 additions & 14 deletions docs/metadata/rules/BUILD
Original file line number Diff line number Diff line change
@@ -1,17 +1,24 @@
load("@bazel_skylib//rules:diff_test.bzl", "diff_test")
load("@stardoc//stardoc:stardoc.bzl", "stardoc")

stardoc(
name = "package_metadata",
out = "package_metadata.generated.md",
input = "@package_metadata//rules:package_metadata.bzl",
deps = [
"@package_metadata//rules:srcs",
],
)

diff_test(
name = "package_metadata_test",
file1 = ":package_metadata",
file2 = "package_metadata.md",
)
[
[
stardoc(
name = file,
out = "{}.generated.md".format(file),
input = "@package_metadata//rules:{}.bzl".format(file),
deps = [
"@package_metadata//rules:srcs",
],
),
diff_test(
name = "{}_test".format(file),
file1 = ":{}".format(file),
file2 = "{}.md".format(file),
),
]
for file in [
"package_metadata",
"package_metadata_toolchain",
]
]
25 changes: 25 additions & 0 deletions docs/metadata/rules/package_metadata_toolchain.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
<!-- Generated with Stardoc: http://skydoc.bazel.build -->

Declares rule `package_metadata_toolchain`.

<a id="package_metadata_toolchain"></a>

## package_metadata_toolchain

<pre>
load("@package_metadata//rules:package_metadata_toolchain.bzl", "package_metadata_toolchain")

package_metadata_toolchain(*, <a href="#package_metadata_toolchain-name">name</a>, <a href="#package_metadata_toolchain-visibility">visibility</a>)
</pre>



**PARAMETERS**


| Name | Description | Default Value |
| :------------- | :------------- | :------------- |
| <a id="package_metadata_toolchain-name"></a>name | <p align="center"> - </p> | none |
| <a id="package_metadata_toolchain-visibility"></a>visibility | <p align="center"> - </p> | `None` |
Comment on lines +22 to +23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The descriptions for the name and visibility attributes are unhelpful placeholders (-). Please provide meaningful descriptions for these common attributes to improve documentation clarity. For example, for name: "A unique name for this target."



6 changes: 6 additions & 0 deletions metadata/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -2,17 +2,23 @@

load("//providers:package_attribute_info.bzl", _PackageAttributeInfo = "PackageAttributeInfo")
load("//providers:package_metadata_info.bzl", _PackageMetadataInfo = "PackageMetadataInfo")
load("//providers:package_metadata_override_info.bzl", _PackageMetadataOverrideInfo = "PackageMetadataOverrideInfo")
load("//providers:package_metadata_toolchain_info.bzl", _PackageMetadataToolchainInfo = "PackageMetadataToolchainInfo")
load("//purl:purl.bzl", _purl = "purl")
load("//rules:package_metadata.bzl", _package_metadata = "package_metadata")
load("//rules:package_metadata_toolchain.bzl", _package_metadata_toolchain = "package_metadata_toolchain")

visibility("public")

# Providers.
PackageAttributeInfo = _PackageAttributeInfo
PackageMetadataInfo = _PackageMetadataInfo
PackageMetadataOverrideInfo = _PackageMetadataOverrideInfo
PackageMetadataToolchainInfo = _PackageMetadataToolchainInfo

# Rules
package_metadata = _package_metadata
package_metadata_toolchain = _package_metadata_toolchain

# Utils
purl = _purl
4 changes: 4 additions & 0 deletions metadata/providers/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ exports_files(
[
"package_attribute_info.bzl",
"package_metadata_info.bzl",
"package_metadata_override_info.bzl",
"package_metadata_toolchain_info.bzl",
],
visibility = ["//visibility:public"],
)
Expand All @@ -11,6 +13,8 @@ filegroup(
srcs = [
"package_attribute_info.bzl",
"package_metadata_info.bzl",
"package_metadata_override_info.bzl",
"package_metadata_toolchain_info.bzl",
],
visibility = ["//visibility:public"],
)
32 changes: 32 additions & 0 deletions metadata/providers/package_metadata_override_info.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
"""Declares provider `PackageMetadataOverrideInfo`."""

visibility("public")

def _init(*, packages, metadata):
return {
"metadata": metadata,
"packages": packages,
}

PackageMetadataOverrideInfo, _create = provider(
doc = """
Defines an override for `PackageMetadataInfo` for a set of packages.
> **Fields in this provider are not covered by the stability gurantee.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "gurantee" should be "guarantee".

""".strip(),
fields = {
"metadata": """
The `PackageMetadataInfo` provider to use instead of the provider declared by
package itself.
""".strip(),
"packages": """
A [PackageSpecificationInfo](https://bazel.build/rules/lib/providers/PackageSpecificationInfo)
provider declaring which packages the override applies to.
This is typically created by a
[package_group](https://bazel.build/rules/lib/globals/build#package_group)
target.
""".strip(),
},
init = _init,
)
22 changes: 22 additions & 0 deletions metadata/providers/package_metadata_toolchain_info.bzl
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
"""Declares provider `PackageMetadataToolchainInfo`."""

visibility("public")

def _init(metadata_overrides = []):
return {
"metadata_overrides": metadata_overrides,
}

PackageMetadataToolchainInfo, _create = provider(
doc = """
Toolchain for `package_metadata`.
> **Fields in this provider are not covered by the stability gurantee.**

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a typo in the docstring: "gurantee" should be "guarantee".

""".strip(),
fields = {
"metadata_overrides": """
A sequence of `PackageMetadataOverrideInfo` providers.
""".strip(),
},
init = _init,
)
2 changes: 2 additions & 0 deletions metadata/rules/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
exports_files(
[
"package_metadata.bzl",
"package_metadata_toolchain.bzl",
],
visibility = ["//visibility:public"],
)
Expand All @@ -9,6 +10,7 @@ filegroup(
name = "srcs",
srcs = [
"package_metadata.bzl",
"package_metadata_toolchain.bzl",
] + [
"//providers:srcs",
],
Expand Down
Loading