Skip to content

Conversation

zifeitong
Copy link
Contributor

@zifeitong zifeitong commented Sep 27, 2025

If you just want to add a single flag (that is per platform) and leave the rest of the default
flags, you have to copy out all the existing flags and add it to what
you have. Instead support just adding an extra flag that is appended to
the default flags.

This is a resubmit of #452 by @rockwotj with minor fixes in documentation.

@fmeum fmeum enabled auto-merge (squash) September 29, 2025 05:11
@fmeum
Copy link
Member

fmeum commented Sep 29, 2025

CI is red, could you take a look?

@zifeitong
Copy link
Contributor Author

CI is red, could you take a look?

ERROR: /root/.cache/bazel/_bazel_root/b467d3f472f868a9ebfc0dcfbcc11203/external/llvm_toolchain_wasm/BUILD.bazel:554:10: @@llvm_toolchain_wasm//:all-components-wasm64 depends on @@llvm_toolchain_wasm_llvm//:bin in repository @@llvm_toolchain_wasm_llvm which failed to fetch. no such package '@@llvm_toolchain_wasm_llvm//': java.io.IOException: Error extracting /root/.cache/bazel/_bazel_root/b467d3f472f868a9ebfc0dcfbcc11203/external/llvm_toolchain_wasm_llvm/temp14323540033465262129/LLVM-19.1.0-Linux-X64.tar.xz to /root/.cache/bazel/_bazel_root/b467d3f472f868a9ebfc0dcfbcc11203/external/llvm_toolchain_wasm_llvm/temp14323540033465262129: write (No space left on device)

Looks like running out of disk space ^^^

@fmeum
Copy link
Member

fmeum commented Sep 29, 2025

This wasn't happening on master, not sure what's up with that.
https://carlosbecker.com/posts/github-actions-disk-space/ has a few ideas for trimming unnecessary bloat. Could you check whether doing that for container_test helps?

@zifeitong
Copy link
Contributor Author

This wasn't happening on master, not sure what's up with that. https://carlosbecker.com/posts/github-actions-disk-space/ has a few ideas for trimming unnecessary bloat. Could you check whether doing that for container_test helps?

I opened #556 which should help. I'll rebase once it's merged.

@fmeum fmeum disabled auto-merge September 30, 2025 05:45
@fmeum fmeum enabled auto-merge (squash) September 30, 2025 05:45
auto-merge was automatically disabled September 30, 2025 06:06

Head branch was pushed to by a user without write access

rockwotj and others added 2 commits September 30, 2025 18:20
If you just want to add a single flag (that is per platform) and leave the rest of the default
flags, you have to copy out all the existing flags and add it to what
you have. Instead support just adding an extra flag that is appended to
the default flags.
@fmeum fmeum requested a review from helly25 as a code owner September 30, 2025 16:20
@fmeum fmeum enabled auto-merge (squash) September 30, 2025 16:20
@fmeum fmeum merged commit 1d0c58f into bazel-contrib:master Sep 30, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants