Skip to content
This repository was archived by the owner on Sep 8, 2023. It is now read-only.

Clarification of priority label semantics #339

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clarification of priority label semantics #339

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8e542e
Clarification of priority label semantics
sventiffe Jan 26, 2022
a51eae2
Update maintainers-guide.md
sventiffe Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions maintaining/maintainers-guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,28 +142,31 @@ issues.
compliant to the [Breaking
Change](https://docs.google.com/document/d/1q5GGRxKrF_mnwtaPKI487P8OdDRh2nN7jX6U-FXnHL0/edit?pli=1#heading=h.ceof6vpkb3ik)
policy. No practical workaround exists.
* Issues marked as P0 are under active development.
* [**P1**](https://github.com/bazelbuild/bazel/labels/P1) - Critical defect or
feature which should be addressed in the next release, or a serious issue that
impacts many users (including the development of the Bazel project), but a
practical workaround exists. Typically does not require immediate action. In
high demand and planned in the current quarter's roadmap.
* Issues marked as P1 are under active development.
* [**P2**](https://github.com/bazelbuild/bazel/labels/P2) - Defect or feature
that should be addressed but we don't currently work on. Moderate live issue
in a released Bazel version that is inconvenient for a user that needs to be
addressed in an future release and/or a easy workaround exists.
* Issues marked as P2 are part of the actively maintained backlog. While the
Bazel team is not actively working on these issues, they are considered to
be re-reviewed at later point in time.
* [**P3**](https://github.com/bazelbuild/bazel/labels/P3) - Desirable minor bug
fix or enhancement with small impact. Not prioritized into Bazel roadmaps or
any imminent release. May never be fixed.
any imminent release. May never be fixed by the Bazel team.
* Issues marked as P3 are not actively managed by the Bazel team.
Community contributions are encouraged, the Bazel team will accept PRs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to mention the help-wanted label somewhere around here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be a good statement?
A bullet point under P3 like "In particular, we welcome contributions to issues with the label "help wanted"." maybe?

While "help wanted" is not restricted to P3 issues, it would be the place where I would mainly expect that label.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a worry about the words "will accept PRs.", even with the "reach out" qualification in the next sentence. I want to avoid repeating our habit of lingering reviews of PRs that address an issue in the authors mind, but are not well thought out.

What about this concept:
Community contributions are welcome. Before sending a PR, please reach out in the issue first to discuss your solution and work with the Bazel team to find the best reviewer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with the suggested wording

Please reach out to the team prior submitting PRs.
* [**P4**](https://github.com/bazelbuild/bazel/labels/P4) - Low priority defect
or feature request that is unlikely to get closed. Can also be kept open for a
potential re-prioritization if more users are impacted.
* [**ice-box**](https://github.com/bazelbuild/bazel/issues?q=label%3Aice-box+is%3Aclosed)
- Issues that we currently don't have time to deal with nor the
time to accept contributions. We will close these issues to indicate that
nobody is working on them, but will continue to monitor their validity over
time and revive them if enough people are impacted and if we happen to have
resources to deal with them. As always, feel free to comment or add reactions
to these issues even when closed.
* Issues marked as P4 are not actively managed until further notice.
Unsolicited PRs will be rejected.

## Team labels

Expand Down