Add cc_import.defines #25690
Closed
Add cc_import.defines #25690
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
awaiting-review
keith
force-pushed
the
ks/add-cc_import.defines
branch
from
7985795 to
b1e52ae
Compare
Member
|
@pzembrod can you take a look? |
pzembrod
approved these changes
May 23, 2025
Contributor
pzembrod
left a comment
pzembrod
left a comment
There was a problem hiding this comment.
Sorry for the delay. I assume the branch will need a resync?
keith
force-pushed
the
ks/add-cc_import.defines
branch
from
27d2f40 to
f1a447e
Compare
keith
force-pushed
the
ks/add-cc_import.defines
branch
from
f1a447e to
0cfa1da
Compare
Member
Author
|
@pzembrod I think we're good here? |
keith
added a commit
to keith/rules_cc
that referenced
this pull request
Aug 14, 2025
This mirrors bazelbuild/bazel#25690 now that this code lives in both places
Member
Author
|
hopefully helpful rules_cc pr bazelbuild/rules_cc#463 |
pzembrod
approved these changes
Oct 31, 2025
pzembrod
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19753