Skip to content

Add Java options to api.proto #1193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add Java options to api.proto #1193

wants to merge 1 commit into from

Conversation

guw
Copy link

@guw guw commented Sep 2, 2023

Put into proper Java package com.google.devtools.buildozer and use BuildozerProtos as class name

@guw
Add Java options to api.proto
d7893b4 
Put into proper Java package
pmbethe09
pmbethe09 reviewed Sep 3, 2023
View reviewed changes
Copy link
Contributor

@pmbethe09 pmbethe09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change for anyone already using Java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmos vladmos Awaiting requested review from vladmos vladmos is a code owner

@larsrc-google larsrc-google Awaiting requested review from larsrc-google

1 more reviewer

@pmbethe09 pmbethe09 pmbethe09 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guw @pmbethe09