support AssignExpr statements in edit.FindRuleByName() #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have what is probably an unconventional style in some of our BUILD files where a macro is used to define several targets and returns a struct of some information so that things like labels of generated targets can be passed as attributes to other targets in the same BUILD file, without the BUILD file needing to hardcode or be aware of the naming convention of the macro's internals. buildozer and unused_deps are unable to operate on targets in `AssignExpr` statements since `edit.FindRuleByName()` and `edit.IndexOfRuleByName()` skip over any nodes that are not call expressions. This commit adapts these functions to be able to find call expressions that are on the right-hand side of an assignment expression. fixes bazelbuild#1306
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have what is probably an unconventional style in some of our BUILD files where a macro is used to define several targets and returns a struct of some information so that things like labels of generated targets can be passed as attributes to other targets in the same BUILD file, without the BUILD file needing to hardcode or be aware of the naming convention of the macro's internals.
buildozer and unused_deps are unable to operate on targets in
AssignExprstatements sinceedit.FindRuleByName()andedit.IndexOfRuleByName()skip over any nodes that are not call expressions. This commit adapts these functions to be able to find call expressions that are on the right-hand side of an assignment expression.fixes #1306