enable_workspace when bazel verison > 8 #1387
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you don't want workspace enabled and are on version 8, unused_deps did not work due to the lack of workspace support. You could either fix this by adding it to your project's bazelrc however we conditionally enable it here depending on the version of bazel being executed. This does have the side-effect that it seems to cause a rebuild due to the arguments of the CLI changing.
fzakaria
commented
Aug 26, 2025
Comment on lines
+86
to
+109
| func bazelMajorVersion() (int, error) { | ||
| out, err := cmdWithStderr(*buildTool, "version").Output() | ||
| if err != nil { | ||
| return 0, err | ||
| } | ||
| lines := strings.Split(string(out), "\n") | ||
| for _, line := range lines { | ||
| if strings.HasPrefix(line, "Build label: ") { | ||
| version := strings.TrimPrefix(line, "Build label: ") | ||
| parts := strings.Split(version, ".") | ||
| if len(parts) < 1 { | ||
| return 0, fmt.Errorf("could not parse version from 'bazel version' output: %s", version) | ||
| } | ||
| var major int | ||
| _, err := fmt.Sscanf(parts[0], "%d", &major) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("could not parse major version from 'bazel version' output: %s", version) | ||
| } | ||
| return major, nil | ||
| } | ||
| } | ||
| return 0, errors.New("could not find version in 'bazel version' output") | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
We could also use this to conditionally, create a MODULE.bazel file and then use override_module instead of repository; I guess both approaches could work and that would probably needed eventually for Bazel 9+ when WORKSPACE is gone.
Member
|
cc @meteorcloudy - I am not sure this is the right thing to do as we are moving away from WORKSPACE |
Member
|
Yes, I think we should move buildtools towards being more MODULE.bazel native. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you don't want workspace enabled and are on version 8, unused_deps did not work due to the lack of workspace support.
You could either fix this by adding it to your project's bazelrc however we conditionally enable it here depending on the version of bazel being executed.
This does have the side-effect that it seems to cause a rebuild due to the arguments of the CLI changing.