Restrict the kind query to start anchor #1388
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had rules such as `pkg_java_library` that were being caught by the kind pattern. Force the prefix kind (i.e. java_) to anchor to the start of the label.
supark-cflt
approved these changes
Aug 26, 2025
AnnaSvalova
requested changes
Nov 6, 2025
| queryCmd = append(queryCmd, blazeFlags...) | ||
| queryCmd = append( | ||
| queryCmd, fmt.Sprintf("kind('(kt|java|android)_*', %s)", strings.Join(targetPatterns, " + "))) | ||
| queryCmd, fmt.Sprintf("kind('^(kt|java|android)_*', %s)", strings.Join(targetPatterns, " + "))) |
There was a problem hiding this comment.
Should the line 365 be updated as well? To match the real command.
Would be nice to have tests as well, but it seems that this file is not covered by any tests =/ Therefore, this is a non-blocking wish.
There was a problem hiding this comment.
the log message?
It's probably fine as is tbh.
There was a problem hiding this comment.
Maybe.. I'd keep everything aligned, but this doesn't really affect user experience.
AnnaSvalova
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had rules such as
pkg_java_librarythat were being caught by the kind pattern.Force the prefix kind (i.e. java_) to anchor to the start of the label.