Set charset instead of encoding in testlog content type
#2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
Contributor
Author
|
@coeuvre Sorry for messing this up again, I don't know how I came up with |
`encoding` doesn't do anything, the correct property is `charset`.
fweikert
approved these changes
Dec 4, 2024
Member
|
No worries! Thanks for the fix. |
Merged
meteorcloudy
pushed a commit
that referenced
this pull request
Dec 6, 2024
Changelog - Set charset instead of encoding in testlog content type #2135
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
…ld#2135) `encoding` doesn't do anything, the correct property is `charset`.
fweikert
pushed a commit
to fweikert/continuous-integration
that referenced
this pull request
Mar 27, 2025
Changelog - Set charset instead of encoding in testlog content type bazelbuild#2135
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
encodingdoesn't do anything, the correct property ischarset.