Also embed a label in non-release builds. #2403
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will show up for example when we someone uses `last_green` with Bazelisk. Fixes bazelbuild/bazel#4275
meisterT
requested review from
Wyverald,
fweikert and
meteorcloudy
as code owners
fweikert
approved these changes
Nov 12, 2025
|
|
||
| def get_release_name_from_branch_name(): | ||
| # TODO(pcloudy): Find a better way to do this | ||
| if os.getenv("BUILDKITE_PIPELINE_SLUG") == "publish-bazel-binaries": |
Member
There was a problem hiding this comment.
You need to pass the label here for the publish-bazel-binaries pipeline, which publish last_green on every commit. maybe removing this if check is enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will show up for example when we someone uses
last_greenwith Bazelisk.Fixes bazelbuild/bazel#4275