Adding implementation for EssentialHighlightingRestarterDisablement #7104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sellophane
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
sellophane
force-pushed
the
essential_analysis_endpoint
branch
2 times, most recently
from
38abebf to
e43e02d
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
3 times, most recently
from
d82bb1f to
e8ef4c2
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
2 times, most recently
from
5bb107c to
9013e67
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
9013e67 to
8a6b88f
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
8a6b88f to
2f3ae4d
Compare
ujohnny
requested changes
Feb 14, 2025
...43/com/google/idea/sdkcompat/querysync/EssentialHighlightingRestarterDisablementAdapter.java
Outdated
Show resolved
Hide resolved
ujohnny
reviewed
Feb 14, 2025
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
2f3ae4d to
7ef90ad
Compare
LeFrosch
requested changes
Feb 17, 2025
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
7ef90ad to
c4afa73
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
c4afa73 to
ef07212
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
ef07212 to
1f60053
Compare
odisseus
approved these changes
Feb 26, 2025
sellophane
force-pushed
the
essential_analysis_endpoint
branch
2 times, most recently
from
3654beb to
0576988
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
0576988 to
daaae15
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
daaae15 to
13bc50e
Compare
LeFrosch
requested changes
Apr 11, 2025
base/BUILD
Outdated
Comment on lines
64
to
70
| "intellij-2024.3": ["src/META-INF/blaze-base-243.xml"], | ||
| "intellij-2025.1": ["src/META-INF/blaze-base-251.xml"], | ||
| "intellij-ue-2024.3": ["src/META-INF/blaze-base-243.xml"], | ||
| "intellij-ue-2025.1": ["src/META-INF/blaze-base-251.xml"], | ||
| "clion-2024.3": ["src/META-INF/blaze-base-243.xml"], | ||
| "clion-2025.1": ["src/META-INF/blaze-base-251.xml"], | ||
| "default": [], |
There was a problem hiding this comment.
This looks like maintenance burden to me. Can we solve this similar to //clwb/src/com/google/idea/blaze/clwb/radler and use something like select_since instead of introducing all these xml files.
sellophane
force-pushed
the
essential_analysis_endpoint
branch
2 times, most recently
from
514ea9d to
68595c9
Compare
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
68595c9 to
9144588
Compare
|
If this is ijwb only, can we move it to ijwb? |
sellophane
force-pushed
the
essential_analysis_endpoint
branch
from
9144588 to
0204509
Compare
github-project-automation
bot
moved this from Untriaged
to Done
in Bazel IntelliJ Plugin
github-actions
bot
removed
the
awaiting-review
sellophane
added a commit
to sellophane/intellij
that referenced
this pull request
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change