Skip to content

Conversation

jmmv
Copy link

@jmmv jmmv commented Jul 16, 2025

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #7799

Description of this change

This prevents targets that are not picked up by the aspect to influence the decision of sharding the sync based on an inaccurate target count.

This is the same as the query sync feature already does.

This prevents targets that are not picked up by the aspect to influence
the decision of sharding the sync based on an inaccurate target count.

This is the same as the query sync feature already does.

Fixes bazelbuild#7799.
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jul 16, 2025
@ujohnny ujohnny assigned LeFrosch and ujohnny and unassigned ujohnny and iliakondratev Jul 18, 2025
@ujohnny ujohnny requested review from sellophane and removed request for mai93 July 18, 2025 14:31
@ujohnny
Copy link
Collaborator

ujohnny commented Jul 22, 2025

@jmmv thanks for the PR, we're a little bit busy these days with the plugin transfer from Google to JetBrains, so I apologize for a delay and we'll get back on this in August.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to have an integration test for this, or at least an example project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-review Awaiting review from Bazel team on PRs product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

6 participants