Skip to content

Rename CacheCapabilities' blob_split_support to split_blob_support and blob_splice_support to splice_blob_support #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Rename CacheCapabilities' blob_split_support to split_blob_support and blob_splice_support to splice_blob_support #340

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions build/bazel/remote/execution/v2/remote_execution.pb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4393,13 +4393,13 @@ type CacheCapabilities struct {
// splitting and a meaningful result can be expected from the
// [ContentAddressableStorage.SplitBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SplitBlob]
// operation.
BlobSplitSupport bool `protobuf:"varint,9,opt,name=blob_split_support,json=blobSplitSupport,proto3" json:"blob_split_support,omitempty"`
SplitBlobSupport bool `protobuf:"varint,9,opt,name=split_blob_support,json=splitBlobSupport,proto3" json:"split_blob_support,omitempty"`
// Whether blob splicing is supported for the particular server/instance. If
// yes, the server/instance implements the specified behavior for blob
// splicing and a meaningful result can be expected from the
// [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
// operation.
BlobSpliceSupport bool `protobuf:"varint,10,opt,name=blob_splice_support,json=blobSpliceSupport,proto3" json:"blob_splice_support,omitempty"`
SpliceBlobSupport bool `protobuf:"varint,10,opt,name=splice_blob_support,json=spliceBlobSupport,proto3" json:"splice_blob_support,omitempty"`
}

func (x *CacheCapabilities) Reset() {
Expand Down Expand Up @@ -4490,16 +4490,16 @@ func (x *CacheCapabilities) GetMaxCasBlobSizeBytes() int64 {
return 0
}

func (x *CacheCapabilities) GetBlobSplitSupport() bool {
func (x *CacheCapabilities) GetSplitBlobSupport() bool {
if x != nil {
return x.BlobSplitSupport
return x.SplitBlobSupport
}
return false
}

func (x *CacheCapabilities) GetBlobSpliceSupport() bool {
func (x *CacheCapabilities) GetSpliceBlobSupport() bool {
if x != nil {
return x.BlobSpliceSupport
return x.SpliceBlobSupport
}
return false
}
Expand Down Expand Up @@ -5999,12 +5999,12 @@ var file_build_bazel_remote_execution_v2_remote_execution_proto_rawDesc = []byte
0x6d, 0x61, 0x78, 0x5f, 0x63, 0x61, 0x73, 0x5f, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x69, 0x7a,
0x65, 0x5f, 0x62, 0x79, 0x74, 0x65, 0x73, 0x18, 0x08, 0x20, 0x01, 0x28, 0x03, 0x52, 0x13, 0x6d,
0x61, 0x78, 0x43, 0x61, 0x73, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x69, 0x7a, 0x65, 0x42, 0x79, 0x74,
0x65, 0x73, 0x12, 0x2c, 0x0a, 0x12, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x70, 0x6c, 0x69, 0x74,
0x65, 0x73, 0x12, 0x2c, 0x0a, 0x12, 0x73, 0x70, 0x6c, 0x69, 0x74, 0x5f, 0x62, 0x6c, 0x6f, 0x62,
0x5f, 0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x09, 0x20, 0x01, 0x28, 0x08, 0x52, 0x10,
0x62, 0x6c, 0x6f, 0x62, 0x53, 0x70, 0x6c, 0x69, 0x74, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
0x12, 0x2e, 0x0a, 0x13, 0x62, 0x6c, 0x6f, 0x62, 0x5f, 0x73, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x5f,
0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x0a, 0x20, 0x01, 0x28, 0x08, 0x52, 0x11, 0x62,
0x6c, 0x6f, 0x62, 0x53, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
0x73, 0x70, 0x6c, 0x69, 0x74, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
0x12, 0x2e, 0x0a, 0x13, 0x73, 0x70, 0x6c, 0x69, 0x63, 0x65, 0x5f, 0x62, 0x6c, 0x6f, 0x62, 0x5f,
0x73, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74, 0x18, 0x0a, 0x20, 0x01, 0x28, 0x08, 0x52, 0x11, 0x73,
0x70, 0x6c, 0x69, 0x63, 0x65, 0x42, 0x6c, 0x6f, 0x62, 0x53, 0x75, 0x70, 0x70, 0x6f, 0x72, 0x74,
0x22, 0xb7, 0x03, 0x0a, 0x15, 0x45, 0x78, 0x65, 0x63, 0x75, 0x74, 0x69, 0x6f, 0x6e, 0x43, 0x61,
0x70, 0x61, 0x62, 0x69, 0x6c, 0x69, 0x74, 0x69, 0x65, 0x73, 0x12, 0x5e, 0x0a, 0x0f, 0x64, 0x69,
0x67, 0x65, 0x73, 0x74, 0x5f, 0x66, 0x75, 0x6e, 0x63, 0x74, 0x69, 0x6f, 0x6e, 0x18, 0x01, 0x20,
Expand Down
8 changes: 4 additions & 4 deletions build/bazel/remote/execution/v2/remote_execution.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ service ContentAddressableStorage {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down Expand Up @@ -514,7 +514,7 @@ service ContentAddressableStorage {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down Expand Up @@ -2266,14 +2266,14 @@ message CacheCapabilities {
// splitting and a meaningful result can be expected from the
// [ContentAddressableStorage.SplitBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SplitBlob]
// operation.
bool blob_split_support = 9;
bool split_blob_support = 9;

// Whether blob splicing is supported for the particular server/instance. If
// yes, the server/instance implements the specified behavior for blob
// splicing and a meaningful result can be expected from the
// [ContentAddressableStorage.SpliceBlob][build.bazel.remote.execution.v2.ContentAddressableStorage.SpliceBlob]
// operation.
bool blob_splice_support = 10;
bool splice_blob_support = 10;
}

// Capabilities of the remote execution system.
Expand Down
8 changes: 4 additions & 4 deletions build/bazel/remote/execution/v2/remote_execution_grpc.pb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,7 +688,7 @@ type ContentAddressableStorageClient interface {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down Expand Up @@ -737,7 +737,7 @@ type ContentAddressableStorageClient interface {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down Expand Up @@ -957,7 +957,7 @@ type ContentAddressableStorageServer interface {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_split_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_split_support]
// [CacheCapabilities.split_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.split_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down Expand Up @@ -1006,7 +1006,7 @@ type ContentAddressableStorageServer interface {
//
// Servers which implement this functionality MUST declare that they support
// it by setting the
// [CacheCapabilities.blob_splice_support][build.bazel.remote.execution.v2.CacheCapabilities.blob_splice_support]
// [CacheCapabilities.splice_blob_support][build.bazel.remote.execution.v2.CacheCapabilities.splice_blob_support]
// field accordingly.
//
// Clients MUST check that the server supports this capability, before using
Expand Down