extensions: gate module_ctx.extension_metadata(reproducible = ...) appropriately
#254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
…appropriately `reproducible` was added in Bazel 7.1.0; gating this argument allows older Bazel versions to use rules_cc 0.0.13 and newer. Note that this change (use of `reproducible`) came from Bazel itself in bazelbuild/bazel#22335; it made its way over to `rules_cc` via bazelbuild@c2549f6 (see bazelbuild/bazel@1c4e78a). More context [here](bazel-contrib/toolchains_llvm#389 (comment)).
rrbutani
force-pushed
the
fix/gate-reproducible-arg
branch
from
14a11be to
55fc267
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reproduciblewas added in Bazel 7.1.0; gating this argument allows older Bazel versions to userules_ccv0.0.13 and newer.Note that this change (use of
reproducible) came from Bazel itself in bazelbuild/bazel#22335; it made its way over torules_ccvia c2549f6 (see bazelbuild/bazel@1c4e78a).More context here.