Add bool_flag for ar flags for macOS #378
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this users can pass `--@rules_cc//cc/toolchains/args/archiver_flags:use_libtool_on_macos=false` to always use ar, even when targeting macOS. This works well for llvm-ar. Fixes bazelbuild#331
keith
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
armandomontanez
approved these changes
Mar 25, 2025
thesayyn
reviewed
Apr 25, 2025
| ) | ||
|
|
||
| config_setting( | ||
| name = "use_libtool_on_macos_setting", |
There was a problem hiding this comment.
Should these targets be public to allow toolchain implementors to select on it?
There was a problem hiding this comment.
Hrm what would be the use case? I guess if you're avoiding this feature maybe you should Add your own flag? Not sure
There was a problem hiding this comment.
Basically this; #403 i am not sure what's the best approach here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this users can pass
--@rules_cc//cc/toolchains/args/archiver_flags:use_libtool_on_macos=falseto always use ar, even when targeting macOS. This works well for
llvm-ar.
Fixes #331