Move compile_{input,output}_flags after compile_flags
#423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we want to have the default flags before the user flags, this does not apply to the input (-c ...) and output (-o ...) flags, as this prevents the user to mark a `.c` file as `-x c++` via `copts = ..`. `gcc` expects that flag before the last `-c ...`
lukasoyen
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
|
cc @keith |
keith
approved these changes
Jun 20, 2025
lukasoyen
force-pushed
the
compiler-inputs-after-copts
branch
from
259a55d to
7495b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we want to have the default flags before the user flags, this does not apply to the input (-c ...) and output (-o ...) flags, as this prevents the user to mark a
.cfile as-x c++viacopts = ...gccexpects that flag before the last-c ...