Make windows toolchain configurable with BAZEL_*OPTS #431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AustinSchuh
requested review from
armandomontanez,
c-mita,
comius,
pzembrod and
trybka
as code owners
This brings the same functionality that exists in Linux to Windows. When cross compiling with transitions, --copts and friends apply to both the host OS, and the target of cross compilation. This necessitates moving all flags to the toolchain. There is no way to do this today for the windows toolchains without writing a toolchain from scratch, which isn't ideal for a couple of small flag changes. While we are here, make `/D_WIN32_WINNT=0x0601` configurable too in the same way, with `BAZEL_WIN32_WINNT`.
AustinSchuh
force-pushed
the
configurable_windows_toolchain
branch
from
3a24287 to
3b661c0
Compare
fmeum
approved these changes
Jul 22, 2025
fmeum
reviewed
Jul 22, 2025
| "tool_bin_path": attr.string(default = "not_found"), | ||
| "tool_paths": attr.string_dict(), | ||
| "toolchain_identifier": attr.string(), | ||
| "win32_winnt_flag": attr.string(default = "/D_WIN32_WINNT=0x0601"), |
Collaborator
There was a problem hiding this comment.
Can we drop this so that the default isn't maintained in two places?
Contributor
Author
There was a problem hiding this comment.
Happy to, done. Took a bit more code since foo(win32_winnt_flag=None) or foo(win32_winnt_flag="") is different than foo().
Looking through the logic some more, user defined options should probably come after the default ones.
fmeum
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the same functionality that exists in Linux to Windows. When cross compiling with transitions, --copts and friends apply to both the host OS, and the target of cross compilation. This necessitates moving all flags to the toolchain. There is no way to do this today for the windows toolchains without writing a toolchain from scratch, which isn't ideal for a couple of small flag changes.
While we are here, make
/D_WIN32_WINNT=0x0601configurable too in the same way.