Added linters to pyo3 tests #3728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
approved these changes
Nov 14, 2025
| - name: Compile requirements | ||
| if: runner.os == 'Windows' | ||
| run: | | ||
| bazel run "$env:TARGET" "--" "--upgrade" "--verbose" |
Collaborator
There was a problem hiding this comment.
Where does $env:TARGET come from here? Is this meant to be ${TARGET}?
Comment on lines
+55
to
+74
| [ | ||
| py_reqs_compiler( | ||
| name = "requirements.{}.update".format(platform), | ||
| requirements_in = "requirements.in", | ||
| requirements_txt = "requirements_{}.txt".format(platform), | ||
| target_compatible_with = select({ | ||
| ":{}".format(platform): [], | ||
| "//conditions:default": ["@platforms//:incompatible"], | ||
| }), | ||
| ) | ||
| for platform in PLATFORMS | ||
| ] | ||
|
|
||
| [ | ||
| py_reqs_solution_test( | ||
| name = "requirements_{}_test".format(platform), | ||
| compiler = ":requirements.{}.update".format(platform), | ||
| ) | ||
| for platform in PLATFORMS | ||
| ] |
Collaborator
There was a problem hiding this comment.
Completely optional, but I tend to combine these into a nested list to avoid needing to repeat the loop:
Suggested change
| [ | |
| py_reqs_compiler( | |
| name = "requirements.{}.update".format(platform), | |
| requirements_in = "requirements.in", | |
| requirements_txt = "requirements_{}.txt".format(platform), | |
| target_compatible_with = select({ | |
| ":{}".format(platform): [], | |
| "//conditions:default": ["@platforms//:incompatible"], | |
| }), | |
| ) | |
| for platform in PLATFORMS | |
| ] | |
| [ | |
| py_reqs_solution_test( | |
| name = "requirements_{}_test".format(platform), | |
| compiler = ":requirements.{}.update".format(platform), | |
| ) | |
| for platform in PLATFORMS | |
| ] | |
| [ | |
| [ | |
| py_reqs_compiler( | |
| name = "requirements.{}.update".format(platform), | |
| requirements_in = "requirements.in", | |
| requirements_txt = "requirements_{}.txt".format(platform), | |
| target_compatible_with = select({ | |
| ":{}".format(platform): [], | |
| "//conditions:default": ["@platforms//:incompatible"], | |
| }), | |
| ), | |
| py_reqs_solution_test( | |
| name = "requirements_{}_test".format(platform), | |
| compiler = ":requirements.{}.update".format(platform), | |
| ), | |
| ] | |
| for platform in PLATFORMS | |
| ] |
Collaborator
Author
There was a problem hiding this comment.
Oh, I'd have done that if automerge didn't see it first 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs
black,isort,mypy, andpylinton all python targets forPyO3to keep tests and examples as clean and correct as possible.Mypy notably tests the stub generation.