FIX: fix for mangling shebang #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without this line, centos8 ARM fails builds with
`*** WARNING {some dependency or file here, such as a readme} is executable but has no shebang, removing executable bit`
This one liner fixes it
|
LGTM |
onlyonehas
approved these changes
Apr 4, 2023
|
I am not sure this should be merged. I think this is a just Warning, it doesn't actually fail the build? However I am not quite clear why all these files have their execute bit set! 
It would be a lot of work getting all these changed - but they shouldn't be marked as executable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this line, centos8 ARM fails builds with
*** WARNING {some dependency or file here, such as a readme} is executable but has no shebang, removing executable bitThis one liner fixes it
h/t to this https://github.com/atom/atom/pull/21964/files