Bug fixes [Issue-136], [Issue-137]

[jcao-bdai]

Bug-fixes:

• Issue-136: missing args (thanks to report by @ManuelZ);
• Issue-137: incorrect type usage (thanks to report by @alsaibie);
• minor: python version bump in sphinx worker.

[myeatman-bdai]

We should change the plot_ellipsoid and all the other plotting functions of this basic shapes to accept pose and pass them into_render3d in the same way you have for `plot_sphere.

[petercorke]

Python 3.8 is already at EOL and may disappear from the GH environment at any time. Suggest we go for something like 3.12 so we don't have to touch this again for a few years.

Also note that checkout action is currently at v4, I don't know what the difference is, or whether the old ones eventually become deprecated.

We should check the python and action versions across all the workflow files, for sphinx building and code coverage.

[petercorke]

We should change the plot_ellipsoid and all the other plotting functions of this basic shapes to accept pose and pass them into_render3d in the same way you have for `plot_sphere.

As is, plot_ellipsoid is completely general, centroid given by centre and shape and orientation by E. pose is not needed and I don't think @jcao-bdai has changed it. We can discuss this more.

In general, adding a pose argument and passing it through is a good thing, because it documents that capability for each plot_xxx function. That capability did exist because a pose argument was picked up by kwargs and passed through to _render, but that's pretty opaque. Bottom line, this is a good addition, but maybe not for plot_ellipse.

[myeatman-bdai]

Approving to close out these changes.