Add q2str to convert quaternion to string#158
Merged
myeatman-bdai merged 2 commits intobdaiinstitute:masterfrom Jan 26, 2025
Merged
Add q2str to convert quaternion to string#158myeatman-bdai merged 2 commits intobdaiinstitute:masterfrom
q2str to convert quaternion to string#158myeatman-bdai merged 2 commits intobdaiinstitute:masterfrom
Conversation
…ity of `qprint(..., file=None)` which is unintuitive. Added deprecation notice to `qprint`, tests and doco.
myeatman-bdai
requested changes
Jan 22, 2025
spatialmath/base/quaternions.py
Outdated
|
|
||
| By default the string is written to `sys.stdout`. | ||
|
|
||
| If `file=None` then a string is returned. |
Collaborator
There was a problem hiding this comment.
I think this line in the doc-string is from a previous version of your code; I don't see a file argument.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
q2str()to convert a quaternion to a string, replacing old functionality ofqprint(..., file=None)which is unintuitive. Added deprecation notice toqprintif this type of call is invoked, butfilecan be set to any valid file-like object reference.Tests and doco provided.