Updated README to add --locked to commands#282
Open
lt25106 wants to merge 5 commits intobergercookie:masterfrom
Open
Updated README to add --locked to commands#282lt25106 wants to merge 5 commits intobergercookie:masterfrom
lt25106 wants to merge 5 commits intobergercookie:masterfrom
Conversation
Author
WillLillis
requested changes
Feb 7, 2026
| push: | ||
| tags: | ||
| - v[0-9]+.* | ||
| branches: |
Collaborator
There was a problem hiding this comment.
Only running the release flow when a tag is pushed that matches a semver version is intentional, this change should be reverted.
| - name: Install dependencies on Linux | ||
| if: startsWith(matrix.target, 'x86_64-unknown-linux') || startsWith(matrix.target, 'aarch64-unknown-linux') | ||
| run: sudo apt-get update && sudo apt-get install -y make openssl libssl-dev | ||
| # Install deps (Linux) |
Collaborator
There was a problem hiding this comment.
If we can get binary releases working on Windows that would be wonderful! I'm pretty wary of these changes however. I'll need to see a passing run of this updated workflow on your fork of asm-lsp before this will be ok to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a lot of people (myself included) being confused and unable to compile it.