Test Python 3.10 and jsonschema 4.x #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhrutledge
commented
Jan 3, 2025
| python-version: | ||
| - "3.8" | ||
| - "3.9" | ||
| - "3.10" |
Owner
Author
There was a problem hiding this comment.
Scanning through the log output, it looks like all version log errors during the test runs (i.e. it's expected behavior). However, the log output format is different between Python 3.8 and Python 3.10:
< test_connection_post_with_exception (tests.http.test_connection.ConnectionTest) ... VWO-SDK - [ERROR]: vwo/http/connection): HTTP Connection - Exception. Error - REQUEST FAILED
---
> test_connection_post_with_exception (tests.http.test_connection.ConnectionTest) ... VWO-SDK - [ERROR]: 805 (vwo/http/connection): HTTP Connection - Exception. Error - REQUEST FAILED
> (vwo/http/connection): HTTP Connection - Exception. Error - REQUEST FAILEDIn Python 3.10, there's an extra number after the log level, and the message is printed twice.
Don't know if this would impact us.
Raw logs:
bhrutledge
commented
Jan 3, 2025
Comment on lines
+118
to
+121
| if sys.version_info >= (3, 10): | ||
| self.assertIs(logger.logger.level, 20) # In Python >=3.10, the default log level is 20 (INFO) | ||
| else: | ||
| self.assertIs(logger.logger.level, 30) # In Python <3.10, the default log level is 30 (WARNING) |
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening this against my fork because wingify#7 requires approval.