Fix bug for strange spectra with 0 mz, intensity in ms2 mzMLs #54
Conversation
WalkthroughThe project version was incremented from "0.0.21" to "0.0.22" in configuration, metadata, and module initialization files. Additionally, the Changes
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the package version from "0.0.21" to "0.0.22" to reflect the bug fix for strange spectra with 0 mz and intensity in ms2 mzMLs.
- Updated version in recipe/meta.yaml.
- Updated version in quantmsutils/init.py.
- Updated package version in pyproject.toml.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| recipe/meta.yaml | Bump package version to 0.0.22 |
| quantmsutils/init.py | Update version variable to 0.0.22 |
| pyproject.toml | Update version field to 0.0.22 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
recipe/meta.yaml (1)
1-46: Ensure newline at end of file.Add a trailing newline to satisfy YAML lint rules and avoid parser warnings.
🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
pyproject.toml(2 hunks)quantmsutils/__init__.py(1 hunks)recipe/meta.yaml(2 hunks)
🧰 Additional context used
🪛 YAMLlint (1.35.1)
recipe/meta.yaml
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
🔇 Additional comments (5)
pyproject.toml (2)
6-6: Confirm version bump and actual bug fix inclusion.The version has been updated from "0.0.21" to "0.0.22". Please ensure that the intended bug fix for handling spectra with 0 m/z and intensity in MS2 mzMLs is present in the codebase, as no implementation changes are visible here.
58-58: Thebuild-backendline was re-saved without modification. No review changes needed.quantmsutils/__init__.py (1)
1-1: Sync package version.Updated
__version__to "0.0.22" to match the new release tag and packaging files.recipe/meta.yaml (2)
4-4: Align conda recipe version.The
meta.yamlversion has been bumped to "0.0.22", consistent withpyproject.tomland__init__.py.
46-46: Add recipe maintainer.The
ypriverolentry has been added underextra.recipe-maintainers. Looks good.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
recipe/meta.yaml (1)
46-46: Add missing newline at end-of-file
YAML lint reports a missing newline at the end of the file. Please append a blank line after the last entry to satisfy the linter.--- a/recipe/meta.yaml +++ b/recipe/meta.yaml @@ line 46 - - ypriverol +\ - ypriverol +🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
environment.yml(1 hunks)recipe/meta.yaml(3 hunks)
✅ Files skipped from review due to trivial changes (1)
- environment.yml
🧰 Additional context used
🪛 YAMLlint (1.35.1)
recipe/meta.yaml
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: build
🔇 Additional comments (3)
recipe/meta.yaml (3)
4-4: Approve version bump to 0.0.22
The package version has been correctly incremented to align with the new release.
27-27: Approvepyopenmsdependency update
Requiringpyopenms>=3.3.0matches the updated upstream fixes and aligns with other environment files.
46-46: Approve addition of recipe maintainer
Addingypriverolto therecipe-maintainerslist ensures proper credit and ownership.🧰 Tools
🪛 YAMLlint (1.35.1)
[error] 46-46: no new line character at the end of file
(new-line-at-end-of-file)
|
Fixing error in bigbio/quantms#535. Thanks to @timosachsenberg for contribution. |
Summary by CodeRabbit