Feat: Enable close button in the "can't-close" state #84
Merged
antobinary merged 2 commits intobigbluebutton:v0.0.xfrom Mar 5, 2026
Merged
Feat: Enable close button in the "can't-close" state #84antobinary merged 2 commits intobigbluebutton:v0.0.xfrom
antobinary merged 2 commits intobigbluebutton:v0.0.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Re-enables the close button when the modal is in the can't-close state.
Motivation
The can't-close behavior was originally implemented to prevent the modal from closing when a user accidentally clicks outside of it after a new selection.
However, blocking the close button is unnecessary. If a user clicks the close button, it is very likely intentional given the small and precise click area.