Skip to content

fix av sync #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix av sync #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/remux/mp4-remuxer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ class MP4Remuxer {
this._mp3UseMpegAudio = !Browser.firefox;

this._fillAudioTimestampGap = this._config.fixAudioTimestampGap;

this._deltaAudioTimestapGap = 0;
}

destroy() {
Expand Down Expand Up @@ -371,13 +373,15 @@ class MP4Remuxer {
let needFillSilentFrames = false;
let silentFrames = null;

this._deltaAudioTimestapGap += sampleDuration - refSampleDuration;
// Silent frame generation, if large timestamp gap detected && config.fixAudioTimestampGap
if (sampleDuration > refSampleDuration * 1.5 && this._audioMeta.codec !== 'mp3' && this._fillAudioTimestampGap && !Browser.safari) {
if (this._deltaAudioTimestapGap > refSampleDuration && this._audioMeta.codec !== 'mp3' && this._fillAudioTimestampGap && !Browser.safari) {
// We need to insert silent frames to fill timestamp gap
needFillSilentFrames = true;
let delta = Math.abs(sampleDuration - refSampleDuration);
let frameCount = Math.ceil(delta / refSampleDuration);
let frameCount = Math.floor(delta / refSampleDuration);
let currentDts = dts + refSampleDuration; // Notice: in float
this._deltaAudioTimestapGap = this._deltaAudioTimestapGap % refSampleDuration;

Log.w(this.TAG, 'Large audio timestamp gap detected, may cause AV sync to drift. ' +
'Silent frames will be generated to avoid unsync.\n' +
Expand Down Expand Up @@ -740,4 +744,4 @@ class MP4Remuxer {

}

export default MP4Remuxer;
export default MP4Remuxer;