Skip to content

Handle polkit timeout during udev setup #2456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ajeem-git wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Handle polkit timeout during udev setup #2456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion common/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
import pluginmanager
import schedule
from storagesize import StorageSize, SizeUnit
from exceptions import PermissionDeniedByPolicy
from exceptions import PermissionDeniedByPolicy, Timeout


class Config(configfile.ConfigFileWithProfiles):
Expand Down Expand Up @@ -1534,6 +1534,15 @@ def _setup_event_based_automation(self):
self.notifyError(str(err))
return False

except Timeout:
msg = _(
'Timed out while waiting for the authentication dialog. '
'Please try again.'
)
logger.error(msg, self)
self.notifyError(msg)
return False

def _setup_schedule_based_automation(self):
"""Update the current users crontab file based on profile settings.

Expand Down
3 changes: 3 additions & 0 deletions common/tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2240,6 +2240,9 @@ def save(self):
== 'com.ubuntu.DeviceDriver.PermissionDeniedByPolicy'):
raise PermissionDeniedByPolicy(str(err)) from err

if err._dbus_error_name == 'org.freedesktop.DBus.Error.NoReply':
raise Timeout() from err

raise err

def clean(self):
Expand Down