Skip to content

Conversation

@hebasto
Copy link
Member

@hebasto hebasto commented Nov 7, 2025

Fixes #1768.

This PR explicitly sets up a virtual environment instead of using uv, as suggested here, for the following reasons:

  1. It does not require granting a third-party action access to the repository.
  2. This approach is already used in other parts of the CI framework (it’s unclear why it was missed in Fix symbol visibility issues, add test for it #1359 in the first place).

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK d3ae054

Let's wait for green.

Thanks for fixing CI so quickly. :)

I agree, that's simpler and does the job. I still think uv is a good idea for devs who want to run the script locally, but that's a different story then.

Copy link
Contributor

@real-or-random real-or-random left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f252da7

@real-or-random real-or-random merged commit c8206b1 into bitcoin-core:master Nov 7, 2025
122 checks passed
@hebasto hebasto deleted the 251107-python-env branch November 7, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: python -m pip install fails with error: externally-managed-environment

2 participants