-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Bitcoin Safe to wallets #4522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
99dcc41 to
10016fe
Compare
10016fe to
1845459
Compare
|
Thanks for your submission! Have you carefully reviewed the criteria for listing and verified that Bitcoin Safe meets those criteria? |
|
@crwatkins Yes I reviewed all criteria and Bitcoin Safe meets all applicable ones imho.
|
|
Thanks much for the careful review. |
Let me know if you agree. I've done dozens of these and I still have to go back and read all the descriptions. |
Sure. I'll do that.
I was orienting myself at Bitcoin.org/_wallets/sparrow.md Line 21 in 7f62c1d
Again I was orienting myself at Bitcoin.org/_wallets/sparrow.md Line 24 in 7f62c1d
Let me know what you think, and what values I should change. |
|
It was quite a while ago, but I think the reason that Sparrow chose that validation score was that I believe Sparrow selects the server randomly by default from a list like described in I'm still leaning toward my recommendation above based on my interpretations, but would be interested in any discussion on the matter as it is often tedious to try to assign these subtly different scores that were created a decade ago to modern wallets, particularly when they sometimes imply that one approach is unconditionally superior to another. |
|
I have reviewed Bitcoin Safe wallet based on the current wallet requirements criteria and my evaluation is below. The summary is that the wallet passes on security and overall design and I'm glad to recommend Bitcoin Safe wallet for listing. A unique characteristic of this wallet is that it does not store keying material nor is it ever exposed to keys. An external hardware wallet is required for signing. Therefore some of the standard requirements below are not applicable. Trezor model T, Coldcard Q, and Foundation Passport were used during the review, but were not evaluated. Also, none of the nostr based features of the wallet were reviewed. A strong feature of the wallet is the exceptionally good user experience for onboarding multivendor, multisignature hardware wallets. It's clear a lot of work has been put into the onboarding, however the wallet is fairly new and the user experience for daily operations (e.g. send, receive, monitoring) is not as polished. Multiple minor issues were reported and it is expected that they will be addressed in future releases. This project is fairly new and has had limited user feedback from the normal sources with a few of them listed below. It is usually expected to have much more user feedback (both good and bad count) to demonstrate a certain ambiguous level of usage before listing. However, since this project does not manage private keys, many of the most common risks are simply not present. Therefore, I'm willing waive the usual high bar of user engagement early and recommend Bitcoin Safe for listing. I concur with the scoring in bc72708. Bitcoin Safe WalletVersion v1.5.0Review Version 2025110901The wallet list is based on the personal evaluation of the maintainer(s) and These requirements are meant to be updated and strengthened over time. Basic requirements:
NOTE Only very minor user engagement was found. Searching for engagement is very difficult because of the name of the project.
PASS No indication
PASS No indication found
PASS No indication. Uses the bdk libraries.
PASS No indication. Test are here https://github.com/andreasgriffin/bitcoin-safe/tree/main/tests
PASS 1.0.0 was released on 15 January 2025
PASS No concerning bug was found. The developer was very responsive to all reported issues.
PASS App has About->Feedback/Contact section
PASS http://bitcoin-safe.org redirects to HTTPS
PASS https://bitcoin-safe.org rating: A+
PASS Developer is Andreas Griffin, OpenSats grant awardee.
PASS A new address is displayed for each transaction
PASS
N/A Bitcoin Safe does not sign transactions
N/A Bitcoin Safe does not store private keys
N/A
Optional criteria (some could become requirements):
PASS Does not show "received from"
FAIL https://bitcoin-safe.org is not included
N/A Bitcoin Safe does not store private keys
PASS
PASS Prints extremely complete worksheets
PASS Uses PBKDF2
PASS |
Adds Bitcoin Safe as a desktop wallet to Bitcoin.org Wallets section.
Supported by opensats
Reproducibility: https://walletscrutiny.com/desktop/bitcoin.safe/
@design-rrr