Skip to content

Fix error in managing-wallets.md in features section #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix error in managing-wallets.md in features section #4533

wants to merge 1 commit into from

Conversation

@luzius1089
Copy link

The field name was wrongly defined as screenshot. This section and the example below are about the features field.

@crwatkins
Copy link
Contributor

Thanks for pointing out this confusing instruction. This line was meant to instruct a submitter on where to put the features key in the YAML file. It was meant to ask the submitter to place it after the screenshot key in the YAML file (for consistency reasons). It would probably be best to not use the term "field" here since this is its first use and it is not defined.

Would you be able to reword this instruction to better describe that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Wallets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@luzius1089 @crwatkins