Skip to content

Conversation

@setavenger
Copy link

@setavenger setavenger commented Nov 15, 2025

Description

Split get_silentpayment_script_pubkey into two functions. Adds a distinct function to compute a silentpayment pubkey. Helps other implementations utilising this crate by exposing more low level functions.

Checklists

All Submissions:

Split get_silentpayment_script_pubkey into two functions. Adds a
distinct function to compute a silentpayment pubkey. Helps other
implementations utilising this crate by exposing more low level
functions.
@nymius
Copy link
Collaborator

nymius commented Nov 16, 2025

Do you have any other use of this function than generate the pubkeys with both parities? I would prefer to not leave to the user the building of the script pubkey, as it may be a source of mistakes. Maybe reducing the return output of the old function to the two possible script pubkeys is better, although I'm not completely happy with that. Returning both TweakedPublicKeys is another alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants