-
Notifications
You must be signed in to change notification settings - Fork 10.3k
[bitnami/jaeger] Add optional Ingress support for Jaeger UI #35744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Aparna M S <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Hi, please let me know if I need to make any changes from my side. I noticed that some pipelines are failing. |
Signed-off-by: Aparna M S <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
Hi @aparnams1999. It looks like the deployment is failing with your changes. Can you try to reproduce it?
|
Signed-off-by: Aparna M S <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Signed-off-by: Aparna M S <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary. |
Description of the change
This change adds optional Ingress support for the Jaeger Query service in the Bitnami Jaeger Helm chart.
Introduces an ingress block in values.yaml to enable configuring hostname, path, ingress class, annotations, and TLS.
Updates the chart templates to conditionally create a Kubernetes Ingress resource targeting the jaeger-query service on port 16686 when ingress is enabled.
Aligns the Jaeger chart with other Bitnami charts that provide native Ingress support, improving deployment automation and ease of use.
Benefits
Simplifies exposing the Jaeger Query UI by allowing users to enable and configure Ingress directly via Helm values.
Eliminates the need for users to manually create and manage separate Ingress resources outside the chart, reducing operational overhead.
Enables consistent and standardized ingress configurations, including support for TLS and annotations for common ingress controllers.
Enhances automation by integrating ingress resource lifecycle with Helm, ensuring Ingress is created, updated, or deleted with the chart.
Brings the Jaeger chart in line with Bitnami’s best practices and other charts that already include native Ingress support.
Possible drawbacks
Not to my knowledge
Applicable issues
Additional information
Tested with NGINX ingress controller on Kubernetes
Checklist
Chart.yaml
according to semver. This is not necessary when the changes only affect README.md files.README.md
using readme-generator-for-helm