[bitnami/redis] Avoid eager evaluation of ternary when resolving user secrets #36265
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… user secrets Helm’s ternary function (from Sprig) is eagerly evaluated, which caused `include "common.secrets.get"` to run even when `.Values.auth.acl.userSecret` was empty. This resulted in errors when the referenced Secret did not exist. Replaced ternary with an explicit `if` guard so that secret lookup is only performed when a userSecret is actually set. Signed-off-by: Sina Safari <[email protected]>
Signed-off-by: Bitnami Bot <[email protected]>
carrodher
added
verify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR fixes an issue in the configmap template where Helm’s
ternaryfunction was used to look up a Kubernetes Secret.Since Sprig’s
ternaryeagerly evaluates both branches, theinclude "common.secrets.get"call was executed even when.Values.auth.acl.userSecretwas empty, causing template rendering to fail if the Secret did not exist.The logic has been replaced with an explicit
ifguard, ensuring that secret lookups only occur when a user-provided Secret name is actually set.Benefits
.Values.auth.acl.userSecretis not provided.Possible drawbacks
userSecret.Checklist
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files.