-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Remove unused actions #36274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused actions #36274
Conversation
886e610
to
54b4ced
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the ci-pipeline will require a higher refactor:
- kubescape is used to get score in main branch and this value is used in VIB as threshold. If we remove VIB, this step doesn't make sense.
- CRDs step has conditions that we will never meet again.
- We could remove all the secrets and use
pull_request
events instead ofpull_request_target
Signed-off-by: Carlos Rodríguez Hernández <[email protected]>
… type Signed-off-by: Fran Mulero <[email protected]>
54b4ced
to
12d08b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR removes some actions that are not used anymore after changes in the offering:
.github/workflows/cd-pipeline.yml
: Helm charts are maintained in terms of code, but no new releases are performed in the index.yaml nor OCI registry.github/workflows/index-monitor.yml
: Index is not updated anymore (although it is not going to be removed).github/workflows/index-update.yml
: Index is not updated anymore (although it is not going to be removed).github/workflows/retry-failed-releases.yml
: There are no more automated PRs to retry in case of failure.github/workflows/ci-pipeline.yml
: Was modified so now it only performs the following actions:Related to #36275