-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-25931] Integrations - can save only if owner #16570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16570 +/- ##
=======================================
Coverage 38.30% 38.30%
=======================================
Files 3403 3403
Lines 97566 97596 +30
Branches 14689 14695 +6
=======================================
+ Hits 37369 37384 +15
- Misses 58568 58583 +15
Partials 1629 1629 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-25931
📔 Objective
Integration save failures occurred because users may not be the owner - that error must be explicit on the client side.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes