Skip to content

Conversation

voommen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-25931

📔 Objective

Integration save failures occurred because users may not be the owner - that error must be explicit on the client side.

📸 Screenshots

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner September 23, 2025 19:24
@voommen-livefront voommen-livefront added the needs-qa Marks a PR as requiring QA approval label Sep 23, 2025
Copy link
Contributor

github-actions bot commented Sep 23, 2025

Logo
Checkmarx One – Scan Summary & Detailsba1c4860-7225-4369-9576-136d5682d07d

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 23, 2025

Codecov Report

❌ Patch coverage is 44.44444% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.30%. Comparing base (daae86e) to head (5ed7125).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...s/services/hec-organization-integration-service.ts 53.84% 18 Missing ⚠️
...rganization-integrations/integrations.component.ts 0.00% 9 Missing ⚠️
...ons/integration-card/integration-card.component.ts 36.36% 7 Missing ⚠️
...s/services/organization-integration-api.service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16570   +/-   ##
=======================================
  Coverage   38.30%   38.30%           
=======================================
  Files        3403     3403           
  Lines       97566    97596   +30     
  Branches    14689    14695    +6     
=======================================
+ Hits        37369    37384   +15     
- Misses      58568    58583   +15     
  Partials     1629     1629           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-qa Marks a PR as requiring QA approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants