Skip to content

Conversation

Banrion
Copy link
Contributor

@Banrion Banrion commented Sep 24, 2025

🎟️ Tracking

PM-25614

📔 Objective

This pull request adds enrichment logic from the pull request: 16005 and adds minor updates to the critical applications service.

Follow up changes:

  • Use enrichment logic when generating a report
  • FIXMEs added
    • Noticed ciphers are fetch multiple times
    • Noticed critical applications service relies on component usage for initializing org details

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Banrion Banrion requested a review from a team as a code owner September 24, 2025 14:28
Copy link
Contributor

github-actions bot commented Sep 24, 2025

Logo
Checkmarx One – Scan Summary & Details7653224d-04fa-43d1-ae88-1ddc81d98b18

Great job! No new security vulnerabilities introduced in this pull request

ttalty
ttalty previously approved these changes Sep 24, 2025
@Banrion Banrion requested a review from ttalty September 25, 2025 20:02
Copy link

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 30.12048% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.29%. Comparing base (e3a5111) to head (1a7b292).
⚠️ Report is 10 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...sk-insights/services/risk-insights-data.service.ts 0.00% 30 Missing ⚠️
...ss-intelligence/critical-applications.component.ts 0.00% 15 Missing ⚠️
...-insights/services/risk-insights-report.service.ts 50.00% 6 Missing ⚠️
...ts/risk-insights/services/critical-apps.service.ts 82.60% 4 Missing ⚠️
.../access-intelligence/access-intelligence.module.ts 0.00% 2 Missing ⚠️
...irt/access-intelligence/risk-insights.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16577      +/-   ##
==========================================
- Coverage   38.30%   38.29%   -0.02%     
==========================================
  Files        3402     3402              
  Lines       97564    97600      +36     
  Branches    14688    14694       +6     
==========================================
+ Hits        37371    37375       +4     
- Misses      58565    58597      +32     
  Partials     1628     1628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Banrion Banrion merged commit 466bf18 into main Sep 26, 2025
61 checks passed
@Banrion Banrion deleted the dirt/pm-25614/risk-insights-data-service-enrichment branch September 26, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants