-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[PM-19300] Session timeout policy #16583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16583 +/- ##
==========================================
+ Coverage 38.86% 38.91% +0.05%
==========================================
Files 3419 3420 +1
Lines 97259 97307 +48
Branches 14611 14619 +8
==========================================
+ Hits 37802 37871 +69
+ Misses 57798 57772 -26
- Partials 1659 1664 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
New Issues (2)Checkmarx found the following issues in this Pull Request
|
…ation dialog when switching between the never and on system lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, a few things to look at from me.
...se/bit-web/src/app/key-management/policies/session-timeout-confirmation-never.component.html
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.html
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.html
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.ts
Outdated
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.ts
Show resolved
Hide resolved
bitwarden_license/bit-web/src/app/key-management/policies/session-timeout.component.ts
Outdated
Show resolved
Hide resolved
|
export class SessionTimeoutPolicy extends BasePolicyEditDefinition { | ||
name = "sessionTimeoutPolicyTitle"; | ||
description = "sessionTimeoutPolicyDescription"; | ||
type = PolicyType.MaximumVaultTimeout; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ To reviewers, do we want to update the naming of the PolicyType
enum too in this PR ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with leaving it as is but will defer to @BTreston since it is AC code.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-19300
📔 Objective
Implements new Session Timeout Policy, which replaces current Vault Timeout Policy.
Key changes:
📸 Screenshots
Video:
2025-10-09.13-51-11.mp4
Screenshots:
Policy in the Policies list:

Policy dialog, when no values have ever been saved. Max allowed timeout dropdown default to not selected:

Policy dialog error, when no values have ever been saved, the max allowed timeout dropdown is not selected, Save button is clicked, shows validation error:

Custom selected:

Non-custom selected:

Never dialog confirmation:

System lock dialog confirmation:

Max allowed timeout dropdown:

Session timeout action dropdown:

Custom validation error when fields are empty:



and
and
Custom validation error toast when both hours and minutes are 0:

Policy saved:

⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes