-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat(auth-tech-debt): [PM-24103] Remove Get User Key to UserKey$ #16589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(auth-tech-debt): [PM-24103] Remove Get User Key to UserKey$ #16589
Conversation
…xed and updated tests.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #16589 +/- ##
==========================================
- Coverage 38.33% 38.27% -0.07%
==========================================
Files 3404 3409 +5
Lines 97618 97837 +219
Branches 14695 14726 +31
==========================================
+ Hits 37421 37445 +24
- Misses 58566 58763 +197
+ Partials 1631 1629 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Great job! No new security vulnerabilities introduced in this pull request |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some questions.
*/ | ||
async confirm(id: string, granteeId: string, publicKey: Uint8Array): Promise<void> { | ||
const userKey = await this.keyService.getUserKey(); | ||
async confirm( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ : is the grantee
and the ActiveUser
different users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a great question, I do not know. Exploring this.
libs/angular/src/auth/login-approval/login-approval-dialog.component.ts
Outdated
Show resolved
Hide resolved
…ed and updated tests.
…ed test variable being made more vague.
|
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24103
📔 Objective
Fixed and updated tests.
📸 Screenshots
N/A
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes