[PM-25982] Assign to Collections - My Items #16591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16591 +/- ##
==========================================
+ Coverage 38.29% 38.31% +0.01%
==========================================
Files 3404 3404
Lines 97591 97608 +17
Branches 14692 14698 +6
==========================================
+ Hits 37373 37398 +25
+ Misses 58591 58585 -6
+ Partials 1627 1625 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shane-melton
previously approved these changes
Sep 25, 2025
jaasen-livefront
previously approved these changes
Sep 25, 2025
Comment on lines
+577
to
+580
| // When all ciphers are either: | ||
| // - unassigned | ||
| // - already in a Default Collection | ||
| // then the Default Collection can be shown. |
There was a problem hiding this comment.
🎨 Maybe we move this up into the above comment instead of at the end of the function?
…t/pm-25982/remove-my-items-collection
nick-livefront
dismissed stale reviews from jaasen-livefront and shane-melton
via
d8d0444
|
shane-melton
approved these changes
Sep 29, 2025
jaasen-livefront
approved these changes
Sep 29, 2025
nick-livefront
deleted the
vault/pm-25982/remove-my-items-collection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-25982
📔 Objective
When assigning a cipher to a collection the Default Collection should not be available if the cipher already exists in a shared collection.
This is a application to assign to collections, bulk assign to collections and add/edit cipher
📸 Screenshots
Screen.Recording.2025-09-24.at.2.26.59.PM.mov
Screen.Recording.2025-09-24.at.9.00.25.PM.mov
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes