Skip to content

Conversation

voommen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26018

📔 Objective

A password change progress card is expected to show the number of outstanding tasks for that organization

📸 Screenshots

Screen layout when metrics are present

image

Screen layout without any metrics

image

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@voommen-livefront voommen-livefront requested a review from a team as a code owner September 25, 2025 17:16
Copy link

Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Details63ea1fa2-b8ee-49ff-99a8-2da840d514b4

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 37.84861% with 468 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.29%. Comparing base (9ff7c0f) to head (f45737e).
⚠️ Report is 51 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...wser/src/vault/popup/settings/archive.component.ts 0.00% 58 Missing ⚠️
apps/desktop/desktop_native/napi/src/lib.rs 0.00% 49 Missing ⚠️
...activity-cards/password-change-metric.component.ts 0.00% 22 Missing ⚠️
libs/auth/src/angular/login/login.component.ts 0.00% 21 Missing ⚠️
...ilter/components/organization-options.component.ts 0.00% 15 Missing ⚠️
...dirt/access-intelligence/all-activity.component.ts 0.00% 15 Missing ⚠️
...2/item-more-options/item-more-options.component.ts 0.00% 14 Missing ⚠️
.../vault-filter/components/vault-filter.component.ts 0.00% 11 Missing ⚠️
libs/components/src/spinner/spinner.stories.ts 0.00% 10 Missing ⚠️
...n-console/organizations/manage/events.component.ts 0.00% 9 Missing ⚠️
... and 73 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16598      +/-   ##
==========================================
+ Coverage   38.13%   38.29%   +0.15%     
==========================================
  Files        3390     3407      +17     
  Lines       97185    97620     +435     
  Branches    14655    14685      +30     
==========================================
+ Hits        37063    37380     +317     
- Misses      58509    58612     +103     
- Partials     1613     1628      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants