Skip to content

Conversation

fntyler
Copy link
Contributor

@fntyler fntyler commented Sep 25, 2025

🎟️ Tracking

BRE-1040

📔 Objective

Add rule to Docker-related file section of CODEOWNERS to include Docker Compose files.

  • rule to match docker-compose.yml

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsa6471ff8-2dff-4b0a-aca5-98d184cabe9a

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.30%. Comparing base (e3a5111) to head (b1a565a).
⚠️ Report is 25 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16600   +/-   ##
=======================================
  Coverage   38.30%   38.30%           
=======================================
  Files        3402     3402           
  Lines       97564    97564           
  Branches    14688    14688           
=======================================
  Hits        37371    37371           
  Misses      58565    58565           
  Partials     1628     1628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fntyler fntyler requested a review from aj-bw September 25, 2025 20:52
@fntyler fntyler merged commit 83e8977 into main Sep 29, 2025
34 checks passed
@fntyler fntyler deleted the bre/bre-1040/docker-compose-co branch September 29, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants