Skip to content

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24633

📔 Objective

This PR fixes another bug related to the original one regarding how child nodes are collected for our collection filters, which they were not previously grouping under the correct collection if there were collections with duplicate names across orgs.

📸 Screenshots

Screen.Recording.2025-09-25.at.1.42.39.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jaasen-livefront jaasen-livefront requested a review from a team as a code owner September 25, 2025 20:43
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb23899ee-d98a-49c0-a63e-6fbc58f8cf79

Great job! No new security vulnerabilities introduced in this pull request

Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 38.30%. Comparing base (24f07dc) to head (1578f44).
⚠️ Report is 76 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rganizations/collections/utils/collection-utils.ts 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16601      +/-   ##
==========================================
- Coverage   38.30%   38.30%   -0.01%     
==========================================
  Files        3403     3402       -1     
  Lines       97566    97572       +6     
  Branches    14688    14689       +1     
==========================================
+ Hits        37377    37379       +2     
- Misses      58561    58565       +4     
  Partials     1628     1628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaasen-livefront jaasen-livefront merged commit ba6f2b7 into main Oct 2, 2025
47 of 50 checks passed
@jaasen-livefront jaasen-livefront deleted the PM-24633-2 branch October 2, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants