Skip to content

Conversation

@Banrion
Copy link
Contributor

@Banrion Banrion commented Sep 25, 2025

🎟️ Tracking

PM-26150

📔 Objective

This pull request adds a guard around the phishing detection service to check if the user has premium.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Banrion Banrion requested a review from a team as a code owner September 25, 2025 20:48
@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2025

Logo
Checkmarx One – Scan Summary & Detailsdb3aee16-9c30-4a5d-aa03-dae391c596e8

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.28%. Comparing base (979e370) to head (9ff1322).
⚠️ Report is 67 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...g-detection/services/phishing-detection.service.ts 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16602      +/-   ##
==========================================
- Coverage   38.29%   38.28%   -0.01%     
==========================================
  Files        3404     3404              
  Lines       97591    97597       +6     
  Branches    14692    14693       +1     
==========================================
- Hits        37373    37369       -4     
- Misses      58591    58602      +11     
+ Partials     1627     1626       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@Banrion Banrion added the needs-qa Marks a PR as requiring QA approval label Sep 30, 2025
@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 1, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 1, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@Banrion Banrion removed the needs-qa Marks a PR as requiring QA approval label Oct 3, 2025
@Banrion Banrion merged commit 33dc578 into main Oct 3, 2025
101 of 103 checks passed
@Banrion Banrion deleted the dirt/pm-26150/premium-guard-phishing-blocker branch October 3, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants