Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements to #919.
DeviceButtonvalues for virtual dpads:thumbstick/upthumbstick/downthumbstick/leftthumbstick/righttouchpad/uptouchpad/downtouchpad/lefttouchpad/righttouchpad/centerXR_EXT_dpad_binding. Since this extension has poor runtime support, emulate it if it's unsupported.dpad/centerand keep it mapped to "dpad".swipe/namespace withswipe/up,swipe/down, etc.swipe/tap? Or a top-levelthumbtapbutton?dpup,dpdown,dpleft,dprighttodpad/left, etc. for consistency.FWIW I'm still kinda on the fence on exposing these at all, the feature seems a little too high level and can be derived from the axis values pretty easily. On the other hand, OpenXR does provide it, it would reduce the verbosity of the input code in the new error screen slightly, and mapping microgestures onto a directional touchpad kinda makes sense. Wanted to sketch out the idea while I think about it more, and allow others to provide feedback.