[4.5] More disable for accesskit and fix Node's accesskit related methods.
#587
Conversation
WhalesState
force-pushed
the
accesskit-blazium
branch
2 times, most recently
from
7e9b53b to
d164bfa
Compare
WhalesState
changed the title
Node's accesskit related methods.Node's accesskit related methods.
WhalesState
force-pushed
the
accesskit-blazium
branch
from
d164bfa to
9cb4573
Compare
| } | ||
| } | ||
|
|
||
| RID RichTextLabel::get_focused_accessibility_element() const { |
There was a problem hiding this comment.
get_focused_accessibility_element() doesn't look like it needs to be moved for this if I am not mistaken.
| String accessibility_description; | ||
| #endif // ACCESSKIT_ENABLED | ||
|
|
||
| void _accessibility_notify_enter(Node *p_node); |
There was a problem hiding this comment.
Were these intended to be in the ACCESSKIT_ENABLED block? If not, they should probably not be moved.
| #endif // ACCESSKIT_ENABLED | ||
| } | ||
|
|
||
| String Window::get_accessibility_name() const { |
There was a problem hiding this comment.
The binding for this looks to be wrapped in an ACCESSKIT_ENABLED check, is something else using it that the function needs to remain with a return String(); placeholder?
| } | ||
| } | ||
|
|
||
| bool Node::_is_accessibility_enabled() const { |
There was a problem hiding this comment.
These functions should remain in the original places so upstream changes are less likely to conflict in future merges if possible.
| #endif // ACCESSKIT_ENABLED | ||
| } | ||
|
|
||
| String Control::get_accessibility_name() const { |
There was a problem hiding this comment.
The binding for this looks to be wrapped in an ACCESSKIT_ENABLED check, is something else using it that the function needs to remain with a return String(); placeholder?
| return ret; | ||
| } | ||
|
|
||
| void Control::set_accessibility_name(const String &p_name) { |
There was a problem hiding this comment.
Can these functions be kept in the original positions so upstream changes are less likely to have merge conflicts if possible?
| String get_accessibility_name() const; | ||
|
|
||
| #ifdef ACCESSKIT_ENABLED | ||
| void set_accessibility_live(DisplayServer::AccessibilityLiveMode p_mode); |
There was a problem hiding this comment.
Is the addition of set_accessibility_live fixing something?
2 participants
Following Godot’s modular design approach, this PR cleans up the codebase by disabling sections of unused code that were still active, improving maintainability and reducing unnecessary compilation.
Note: This change also removes some methods from the documentation by default. If there are plans to re-enable this feature in the future, we can add dummy methods to preserve the related documentation entries.