Add support for base_url parameter in ServerBasedAPIAccessControl#69
Merged
dmgav merged 2 commits intobluesky:mainfrom Jun 5, 2025
Merged
Conversation
matyson
force-pushed
the
support-base-url-api-access-policy
branch
from
89bce0e to
2f3b54c
Compare
…cept base_url the proposed discriminated union was not working and would require the creation of a subschema inside this schema, so for simplicity if base_url is included it takes priority over the server+port defaults
matyson
force-pushed
the
support-base-url-api-access-policy
branch
from
2f3b54c to
500113c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for
base_urlparameter toServerBasedAPIAccessControlDescription
Added a
base_urlparameter toServerBasedAPIAccessControlpolicy as an option to the currentserver+portparameters to generate the URL to query for authorization access.This change enables
httpsrequests and domain names that can rely on default http ports, i.e. :80 or :443, as well as services deployed under path parameters behind a reverse proxy, e.g.https://myserver.example.com/access-api.Motivation and Context
I wanted to setup my
http-serverto query an external service for authorization and it was not able to request the server since the current generatedbase_urldoes not support full URLs, so it constructs the URL withouthttpsand without a required path parameter.Summary of Changes for Release Notes
Added
base_urlparameter inServerBasedAPIAccessControlpolicy.How Has This Been Tested?
Since it only changes a class property initialization, would appreciate some guidance on what a relevant test would be. Should I replicate the current policy testing only changing the init argument?