QualifiedNode, Matrix, Function support and more #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 21 commits
December 12, 2017 05:35
…ect and parameter setvalue on server
|
Hi @dufourgilles! I'm using your lib. But one question I have: how do I execute functions? It's not clear to me :/ Thanks for your help and your great work! |
added 8 commits
January 11, 2018 04:54
…cribers. Fixed getDirectory and setValue to send proper response.
… if value has not changed
… to provide above app a way to decide if connection allowed or not
…w() function from NRKNO fork
doc: Added comments to explain reason for hack
Feat/timeout hack
Fix client parameter subscribe
Feat/timeout hack - setValueNoAck()
Update from main repo
Export BER module for manual encoding
* Added supported for Function on server side. Fixed invokationresult decoding * new documentation * Added all matrixConnect and Disconnect functions. Fixed all tests. Modified the Doc. * Add description to label when converting json to tree * Adding validation of connection request on server * fix contributors * Fixing getDirectory when root has more than 1 elements * Added support for subscribe and unsubscribe of streams * fixing matrix absolute connect * Better error when doing getNodeByPath * handle connection for 1-to-1 matrix * add maximumTotalConnects * fix 1 to N matrix connect * Fix 1toN. Disconnect old source and connect to new one * Server should emit disconnect when connecting target with new source * Update doc * Do a disconnect if attempting to connect same src and target * fix disconnect * handle connect with empty sources * added lock/unlock of connection * Fix disconnect for 1toN * Fix function result missing * Added -1 for defaultSources to disable disconnect * fix disconnect when mismatch client server * Fix bug in command handling * fix continuation message * Ignore empty request on server * catch write error and disconnect * Removed all ref to callabcks...using different approach...Added support for subscribe * Fix toJSON for root * version 2 * Finalized version 2.0.0 * version 2 final fixes and good to go * Fixing missing EmberLib file. Added server events * Change server event format to include source ip:port * Fix setValue event to be inline with the other events * Fixed eslint errors * Adding Streams. Fixing bugs. Event/Errors using static value * Added code coverage for Parameter * Matrix code coverage. Bug fixing * Adding test code coverage. EmberLib 100% upto Matrix * Added support for Template and QualifiedTemplate. Improved code coverage. * 92% code coverage * Add missing files. Reformat S101Socket and S101Client * v2.4.2 * use latest asn1 lib * Fixed some client missing promise return. Add server preMatrixConnect to provide above app a way to decide if connection allowed or not * Fix matrix handling on server side * Fixed tests. Changed server listen function to return promise * Added example for setValue * Fix duplicate dataIn * Fix FunctionContent result encoding * fix expand and function content encoding/decoding * feat: hack setValue to immediately resolve - added setValueWithHacksaw() function from NRKNO fork * feat: setValueNoAck - rename of function and cleanup * fix: promise didn´t resolve doc: Added comments to explain reason for hack * Fix client parameter subscribe * Add support for streamDescriptor parsing from json * Fixed tests * feat: export BER in index.js for manual ASN.1 encoding Co-authored-by: Gilles Dufour <[email protected]> Co-authored-by: Kasper Olsson Hans <[email protected]>
TreeNode.js: fix toJSON() when there are no children Ember.test.js: fix tests, cleaned up imports
…de_to_json Bugfix/fix tests and treenode to json
* Fixed TreeNode and tests TreeNode.js: fix toJSON() when there are no children Ember.test.js: fix tests, cleaned up imports * rewrote line in better js Co-authored-by: Thomas Silvestre <[email protected]>
Bugfix/matrix target validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks a lot for the great work on ember+.
I was working on a node wrapper for the c++ library but it was very complex and before I could finish I notice your work.
I have added all the features that I need in my environment. Also fixed some issues with multi packets, packet delimitation, ... also modified asn1 package to support indefinite length object.
You will also notice that I changed the way we connect() to the device and then retrieve the root and then expand() it.
Just wanted you to be aware of my work. Feel free to integrate it or not in your project.
Thanks,
Gilles Dufour